sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

cluster-api : Updated error check #171

Closed thpang closed 2 years ago

thpang commented 2 years ago

The testing team found this when testing the repo that shows we do not successfully ignore the "error: no objects passed to apply" condition.

Output example from the task:

TASK [vdm : prereqs - cluster-api] *********************************************
fatal: [localhost]: FAILED! => {"changed": true, "cmd": "kubectl --kubeconfig /config/kubeconfig apply -n production --selector=\"sas.com/admin=cluster-api\" -f /data/viyabyo-landy-gke/production/site.yaml\nkubectl --kubeconfig /config/kubeconfig wait --for condition=established --timeout=60s -l \"sas.com/admin=cluster-api\" crd\n", "delta": "0:00:02.791138", "end": "2021-12-02 17:05:39.029596", "failed_when_result": true, "msg": "", "rc": 0, "start": "2021-12-02 17:05:36.238458", "stderr": "error: no objects passed to apply", "stderr_lines": ["error: no objects passed to apply"], "stdout": "customresourcedefinition.apiextensions.k8s.io/casdeployments.viya.sas.com condition met\ncustomresourcedefinition.apiextensions.k8s.io/espconfigs.iot.sas.com condition met\ncustomresourcedefinition.apiextensions.k8s.io/esploadbalancers.iot.sas.com condition met\ncustomresourcedefinition.apiextensions.k8s.io/esprouters.iot.sas.com condition met\ncustomresourcedefinition.apiextensions.k8s.io/espservers.iot.sas.com condition met\ncustomresourcedefinition.apiextensions.k8s.io/espupdates.iot.sas.com condition met\ncustomresourcedefinition.apiextensions.k8s.io/opendistroclusters.opendistro.sas.com condition met\ncustomresourcedefinition.apiextensions.k8s.io/pgclusters.webinfdsvr.sas.com condition met", "stdout_lines": ["customresourcedefinition.apiextensions.k8s.io/casdeployments.viya.sas.com condition met", "customresourcedefinition.apiextensions.k8s.io/espconfigs.iot.sas.com condition met", "customresourcedefinition.apiextensions.k8s.io/esploadbalancers.iot.sas.com condition met", "customresourcedefinition.apiextensions.k8s.io/esprouters.iot.sas.com condition met", "customresourcedefinition.apiextensions.k8s.io/espservers.iot.sas.com condition met", "customresourcedefinition.apiextensions.k8s.io/espupdates.iot.sas.com condition met", "customresourcedefinition.apiextensions.k8s.io/opendistroclusters.opendistro.sas.com condition met", "customresourcedefinition.apiextensions.k8s.io/pgclusters.webinfdsvr.sas.com condition met"]}

Creating a PR to fix this.