search

sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

v1beta1 breaks 2021.2.4 #187

Closed StuartAAustin closed 2 years ago

StuartAAustin commented 2 years ago

These 2 lines in the default template for kustomization.yaml break deployments at 2021.2.4 since v1beta1 is not supported:

kind: Kustomization apiVersion: kustomize.config.k8s.io/v1beta1

https://github.com/sassoftware/viya4-deployment/blob/main/roles/vdm/templates/kustomization.yaml#L1-L2

thpang commented 2 years ago

This is for a kubernetes v1.22 deployment with Ingress 1.1.0? Also can you provide the kustomize command you're running and the output to show the actual error. Thanks.

jkmin96 commented 2 years ago

I didn't have any problem with it when I ran deployment on 1.21.x or 1.22.x using internal PG or external PG. It is true that IAC creates kustomization.yaml using those two lines but when I created site.yaml files with and without those two lines, both site.yaml files are same. There was no difference. So, I'm not sure if those two lines affected on your deployment.

thpang commented 2 years ago

@StuartAAustin can you let us know the status here? We're looking to close this one and from @jkmin96's comment it seems to be working. We'll be closing this one at the end of the day if you don't respond. Thanks.