sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

feat: (IAC-480) Change default certificate generator to openssl #245

Closed jarpat closed 2 years ago

jarpat commented 2 years ago

Changes

Makes the new default for V4_CFG_TLS_GENERATOR to openssl. Also changes CERT_MANAGER_ENABLED to false so cert-manager does not get installed during the baseline by default.

Tests

See internal IAC-480 ticket

jarpat commented 2 years ago

Just a general comment here. There is no parity between what used to be in place for the cert-manager and openssl that was installed during the deployment repo install phase. Would be nice, if possible to have openssl as part of the baseline to keep things aligned.

I think this is ready for re-review after the discussion we had last week.