sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

(IAC-617) Wrong variable is being defaulted to /export #254

Closed AWSmith0216 closed 2 years ago

AWSmith0216 commented 2 years ago

The baseline role currently defaults V4_CFG_RWX_FILESTORE_ENDPOINT to /export; this is almost certainly meant to be V4_CFG_RWX_FILESTORE_PATH (same as the VDM role).

AWSmith0216 commented 2 years ago

@thpang , given your comment, does that mean you want me to merge this into staging, or do you prefer someone on your team to do so?

thpang commented 2 years ago

Someone on our team will merge it. Just wanted to have it off the queue and ready to rock and roll when the team gives it the green light. Thanks again.

thpang commented 2 years ago

Looking to have a couple more of your review.