search

sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

fix: (IAC-586) Correct the ingress-nginx annotations #255

Closed jarpat closed 2 years ago

jarpat commented 2 years ago

Changes

Fix the default INGRESS_NGINX_CONFIG so that annotation is now correctly annotations

Tests

More details and artifacts in the internal ticket

Summary

  1. Created a private cluster using the IAC code and ensured V4_CFG_INGRESS_MODE would be set to "private" before running viya4-deployment
  2. I adjusted private_ingress annotation variable for azure to include an additional annotation for testing, to mimic the issue reported in IAC-586
  3. Ran baseline,install and verified that the ingress-nginx-controller service object correctly contained both of my annotations (proxy-buffering & azure-load-balancer-internal)
jumpuser@jarpat-pr-byo-jump-vm:/opt/viya4-deployment$ kubectl get service -n ingress-nginx ingress-nginx-controller -o yaml
apiVersion: v1
kind: Service
metadata:
  annotations:
    meta.helm.sh/release-name: ingress-nginx
    meta.helm.sh/release-namespace: ingress-nginx
    nginx.ingress.kubernetes.io/proxy-buffering: "on"
    service.beta.kubernetes.io/azure-load-balancer-internal: "true"
...truncated