sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

Container Registry tokens should not be mandatory #29

Closed erwangranger closed 3 years ago

erwangranger commented 3 years ago

In the doc for registry access tokens, it says that those tokens are mandatory.

In the case of external orders, however, these tokens are embedded by default in the deployment assets and there is nothing special to do to access the images.

Ideally, if a user does not specify those tokens, we should just not build the cr_access.json file and not reference it in the kustomization.yaml. (I believe it's done here )