sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

feat: (IAC-707) Remove CERT_MANAGER_ENABLED and use V4_CFG_TLS_GENERATOR #299

Closed jarpat closed 2 years ago

jarpat commented 2 years ago

Changes

Before if a user wanted to use cert-manager in their cluster they need to set two flags: V4_CFG_TLS_GENERATOR:cert-manager & CERT_MANAGER_ENABLED:true V4_CFG_TLS_GENERATOR controlling the TLS generator that Viya will use, and CERT_MANAGER_ENABLED controlling whether or not cert-manager should be installed by the DaC codebase. Even though it is documented to use both, often times user's only set one of these two flags resulting in issues.

This change makes is so that if the user sets V4_CFG_TLS_GENERATOR:cert-manager, it will now install cert-manager during the baseline stage, so we no longer need to manage two variables for cert-manager. CERT_MANAGER_ENABLED is now removed since setting V4_CFG_TLS_GENERATOR:cert-manager provides the same functionality.

Tests

More details in internal ticket