search

sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

fix: (IAC-964) Update kubernetes-sigs nfs-provisioner #419

Closed stturc closed 1 year ago

stturc commented 1 year ago

Changes

Update the client chart version for the nfs-subdir-external-provisioner from 4.0.8 to 4.0.18 so that we will pull the provisioner image from the registry.k8s.io container registry instead of the deprecated k8s.gcr.io container registry.

Testing

Scenario DAC deployment tasks Notes
Prior to chart version change "baseline, cluster-logging, viya, install" Filtered list indicates the only image pulled from k8s.gcr.io as: k8s.gcr.io/sig-storage/nfs-subdir-external-provisioner:v4.0.2
After chart version change "baseline, cluster-logging, cluster-monitoring, viya, install" All pods stabilized, sas and pg-storage related PVCs are bound with no errors. Filtered list shows the new CR location for the image above as: registry.k8s.io/sig-storage/nfs-subdir-external-provisioner:v4.0.2

The following command was used to create the list of image locations for containers present in the deployment:

kubectl get pods --all-namespaces \
-o jsonpath="{.items[*].spec.containers[*].image}" |\
tr -s '[[:space:]]' '\n' |\
sort |\
uniq -c

Information from Stephen:

Due to the pending depreciation of k8s.gcr.io and redirect to registry.k8s.io, we need to move to a newer version of kubernetes-sigs for the nfs-subdir-external-provisioner to get the image registry update. This is affecting some of our environments where we have stricter controls in place and the redirect is not working. Eventually the redirect will be removed as well, so it is probably a good time to do this.

More information: https://kubernetes.io/blog/2023/03/10/image-registry-redirect/ https://www.reddit.com/r/devops/comments/11sm10g/deprecation_alert_mar_20_traffic_from_the_old/

dhoucgitter commented 1 year ago

Thanks @jarpat, good catch. Pushed a new commit for your review.