search

sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
70 stars 64 forks source link

fix: (IAC-939) Prevent metrics-server Tasks From Running on Non-AWS Clusters #423

Closed jarpat closed 1 year ago

jarpat commented 1 year ago

Changes

Update the metrics server task so that the tasks will only be included if the provider value is set to "aws". The Remove metrics-server server task has also been updated so that it is now also controlled by the METRICS_SERVER_ENABLED variable, if set to false this task can be skipped.

Tests

Ran through the following tests, see internal ticket for additional details.

Scenario Provider K8s Version Order Cadence METRICS_SERVER_ENABLED Process Notes
1 OSS-VMWare v1.25.6 ** fast:2020 unset (defaults to TRUE) viya,baseline,install -> viya,baseline,uninstall The metrics-server installed by viya4-iac-k8s was not modified
2 AWS v1.24.10-eks-48e63af ** fast:2020 unset (defaults to TRUE) baseline,install -> baseline,uninstall metrics server installed and uninstalled
3 AWS v1.24.10-eks-48e63af ** fast:2020 TRUE baseline,install -> baseline,uninstall metrics server installed and uninstalled
4 AWS v1.24.10-eks-48e63af ** fast:2020 FALSE baseline,install -> baseline,uninstall metrics server not installed and not uninstalled
5 AWS v1.24.10-eks-48e63af ** fast:2020 TRUE -> FALSE baseline,install -> baseline,uninstall metrics server installed and not uninstalled