sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
70 stars 64 forks source link

Suggestion: publish docker images #436

Closed momiji closed 9 months ago

momiji commented 1 year ago

Hello,

is it possible to publish prebuilt docker images, based on tags for example, in dockerhub and ghcr (github container registry), like this: https://github.com/users/momiji/packages/container/viya4-deployment/versions.

I don't think it is important to worry about the viya-deployment ansible playbook included in the docker image (which is still required because build relies on requirements.txt), as we can override it during runtime:

My usage is something like this:

$ docker run --rm -it
    ... \
    -v $PWD/viya4-deployment:/viya4-deployment.new:ro \
    -v $PWD/viya4-entrypoint.sh:/viya4-entrypoint.sh:ro \
    ... \
    --entrypoint $PWD/viya4-entrypoint.sh \
    sassoftware/viya4-deployment:6.4 \
    --tags install,viya

with a viya4-entrypoint.sh like this:

#!/usr/bin/env bash
set -ex

[ -d /ca-certs/ ] && {
    install -m 0750 -d /usr/local/share/ca-certificates/ca-certs/
    ls /ca-certs/ | xargs -i cp /ca-certs/{} /usr/local/share/ca-certificates/ca-certs/{}.crt
    update-ca-certificates
}

[ -d /viya4-deployment.new/ ] && {
    rsync -a /viya4-deployment.new/ /viya4-deployment/ --delete --exclude /.ansible
}

chmod +x /viya4-deployment/docker-entrypoint.sh

cmd=/viya4-deployment/docker-entrypoint.sh
[ "${1:-}" = "bash" ] && cmd=/bin/bash && shift

exec $cmd "$@"
jarpat commented 9 months ago

This requires PM review

jarpat commented 9 months ago

Hey @momiji,

For legal and support reasons we are not able to publish images to the docker hub. We supply the dockerfile so you are able to build it yourself using docker build https://github.com/sassoftware/viya4-deployment/blob/main/docs/user/DockerUsage.md#docker-image

momiji commented 9 months ago

Hum, can you give more information on the legal/support reasons? I was feeling it to just be a docker image with pre-installed requirements and nothing more.

I'm intersted because as I do publish the images for my own usage, you've just worried me...