sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
70 stars 64 forks source link

feat: (IAC-1104) Replace nfs-subdir-external-provisioner with nfs.csi.k8s.io #457

Open Carus11 opened 1 year ago

Carus11 commented 1 year ago

Hi all I propose we replace nfs-subdir-external-provisioner with the csi driver for nfs https://github.com/kubernetes-csi/csi-driver-nfs . The nfs-subdir-external-provisioner suffers from a lack of maintainers and the kubernetes sig-storage group recommends people move away from use of this project to the csi driver for nfs. See meeting notes march 10th 2022: https://docs.google.com/document/d/1-8KEG8AjAgKznS9NFm3qWqkGyCHmvU6HVl0sk5hwoAE/edit?pli=1#heading=h.39gn7e729u4t

This lack of maintainers was especially evident earlier this year when users tried to address several security scan items in the nfs-subdir-external-provisioner container image. It also appears to be a candidate for deprecation and in slack they also recommend against using it.

nealman13 commented 1 year ago

I tried replacing nfs-subdir-external-provisioner with nfs.csi.k8s.io, and then deploying Viya 2023.08.

Everything worked except for the sas-pyconfig job. The sas-pyconfig pods would fail with the following message:

{"level":"info","version":1,"source":"pyconfig","messageKey":"Start of Pyconfig","messageParameters":{},"properties":{"caller":"go/main.go:1280"},"timeStamp":"2023-08-24T14:56:41.862470+00:00","message":"Start of Pyconfig [elapsed time:0m:0s:0ms name:startup]"} {"level":"fatal","version":1,"source":"pyconfig","messageKey":"Cannot write to PVC configured in global.pvc. Path: /opt/sas/viya/home/sas-pyconfig","messageParameters":{},"properties":{"caller":"go/main.go:1290"},"timeStamp":"2023-08-24T14:56:42.250099+00:00","message":"Cannot write to PVC configured in global.pvc. Path: /opt/sas/viya/home/sas-pyconfig [elapsed time:0m:0s:388ms name:validateData]"}