search

sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
70 stars 64 forks source link

feat!: (IAC-1014) update orchestration deploy to orchestration deploy manifest #460

Closed jarpat closed 1 year ago

jarpat commented 1 year ago

Changes

Swap the sas-orchestration deploy deployment method to instead be sas-orchestration deploy manifest a sas-orchestration experimental deployment method which deploys Viya using a site.yaml rather file than a SASDeployment.yaml CRD file.

To use this feature, set the existing variable in your ansible-vars.yaml V4_DEPLOYMENT_OPERATOR_ENABLED:false.

The sas-orchestration deploy option which uses the CRD has been removed.

Tests

Scenario Provider K8s Version Deployment Method Orchestration Cadence Order Task
1 GCP v1.26.5-gke.2100 ansible deploy manifest fast:2020 ** viya install & uninstall
2 GCP v1.26.5-gke.2100 docker deploy manifest fast:2020 ** viya install & uninstall
3 GCP v1.26.5-gke.2100 ansible deploy manifest fast:2020 ** MT
4 GCP v1.26.5-gke.2100 docker deploy manifest fast:2020 ** MT
5 GCP v1.26.5-gke.2100 ansible deploy manifest fast:2020 ** BTL
6 GCP v1.26.5-gke.2100 docker deploy manifest fast:2020 ** BTL
7 GCP v1.26.5-gke.2100 docker deployment operator fast:2020 ** viya install & uninstall
jarpat commented 1 year ago

LGTM, consider running ansible-lint against your changed files with .ansible-lint in #459 to check for any rule violations

@dhoucgitter, if you agree, I think for now I am going to forgo ansible linting this PR with the upcoming linter implementation PR #459 since this is currently going into a experimental branch. The timing of the "public" release of this feature has yet to be determined.

That being said, after each viya4-deployment release I do plan on rebasing this experimental "deploy-manifest-site-yaml" branch. When the linter implementation changes in #459 gets released (probably after the next planned release?) a rebase will pick up those changes and I'll end up having to fix the warnings that start getting reported for the 4 files I modified. A quick check says the issues are only key-order and task name casing in the 4 files so it shouldn't be a significant change.

I put a note in IAC-1102, the ticket to release this feature, to also consider any linting changes I may have to make.

dhoucgitter commented 1 year ago

LGTM, consider running ansible-lint against your changed files with .ansible-lint in #459 to check for any rule violations

@dhoucgitter, if you agree, I think for now I am going to forgo ansible linting this PR with the upcoming linter implementation PR #459 since this is currently going into a experimental branch. The timing of the "public" release of this feature has yet to be determined.

That being said, after each viya4-deployment release I do plan on rebasing this experimental "deploy-manifest-site-yaml" branch. When the linter implementation changes in #459 gets released (probably after the next planned release?) a rebase will pick up those changes and I'll end up having to fix the warnings that start getting reported for the 4 files I modified. A quick check says the issues are only key-order and task name casing in the 4 files so it shouldn't be a significant change.

I put a note in IAC-1102, the ticket to release this feature, to also consider any linting changes I may have to make.

sure, sounds good Jay