search

sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
70 stars 64 forks source link

fix: (IAC-1242) where are V4_CFG_RWX_FILESTORE_ASTORES_PATH and V4_CFG_RWX_FILESTORE_BIN_PATH variables actually being used in this project? #493

Closed miaeyg closed 3 months ago

miaeyg commented 11 months ago

Viya4 Deployment Version Details

Deploy on Azure

Ansible Variable File Details

No response

Steps to Reproduce

Deploy SAS Viya 4 on Azure using a Jump server and an NFS Server

Expected Behavior

I would expect the V4_CFG_RWX_FILESTORE_ASTORES_PATH and V4_CFG_RWX_FILESTORE_BIN_PATH variables to be used somewhere in the deployment but cannot find any such usage. Can someone please tell me?

Actual Behavior

No usage found for these defined variables in the deployment files

Additional Context

No response

References

No response

Code of Conduct

sayeun commented 10 months ago

Have you looked at https://github.com/sassoftware/viya4-deployment/blob/main/docs/CONFIG-VARS.md#storage ?

miaeyg commented 10 months ago

Yes, I am aware that these options are documented but I cannot find anywhere within the project where they are actually being used. I searched all files for these two variables and got zero results. I am wondering if these options are being used at all...

jarpat commented 9 months ago

Hey @miaeyg.

I do see that we create the astores and bin directory here https://github.com/sassoftware/viya4-deployment/blob/main/roles/jump-server/tasks/main.yml#L41 but it's always going to be created under JUMP_SVR_RWX_FILESTORE_PATH

Looking at old PRs when this V4_CFG_RWX_FILESTORE_ASTORES_PATH was initially renamed it seems that it was never used then either, perhaps it was a placeholder? PR #43

An internal Jira story will be created to track this.