search

sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

fix: (IAC-1485) Update Docker dependency to Resolve issue with requests #553

Closed jarpat closed 4 months ago

jarpat commented 4 months ago

Changes

Pin docker==7.1.0 in requirements.txt and community.docker=3.10.3 in requirements.yaml

Resolves an issue found in the docker-py project where the latest version of requests was breaking it. See info here: https://github.com/docker/docker-py/issues/3256

Summary of issue:

  1. The docker-py project pinned their requirements for the requests dep at ">= 2.26.0"
  2. version 2.32.0 of requests just released on May 20th which broke the docker-py project.
    • This new version renamed a function as a result of some CVE they needed to resolve

Tests

Scenario Provider K8s Version Order Cadence Execution Notes
1 Azure v1.29.4 * fast:2020 ansible on host Ansible, DEPLOY: false, just verifying that docker pull task works again
2 Azure v1.29.4 * fast:2020 ansible inside docker container Docker, DEPLOY: false, doesn't affect this environment, sanity test