search

sassoftware / viya4-deployment

This project contains Ansible code that creates a baseline in an existing Kubernetes environment for use with the SAS Viya Platform, generates the manifest for an order, and then can also deploy that order into the Kubernetes environment specified.
Apache License 2.0
71 stars 64 forks source link

Add vars for configuring 3rd party helm chart #96

Closed NormJohnIV closed 3 years ago

NormJohnIV commented 3 years ago

Add vars to config settings for the 3rd party helm charts

  1. Repo url
  2. Repo version
  3. Helm values
  4. Helm release name
  5. Deployment namespace (except for metrics-server which always deploys in kube-system.)

Also, bumped cert-manger version to 1.3.0

thpang commented 3 years ago

Only AWS requires us to install the metric server Azure/GCP already install that item. We don't know the current version that they are installing. But we can control the AWS item.

From: Heather Hewlett @.> Sent: Thursday, May 27, 2021 3:36 PM To: sassoftware/viya4-deployment @.> Cc: Thomas Pangborn @.>; Review requested @.> Subject: Re: [sassoftware/viya4-deployment] Add vars for configuring 3rd party helm chart (#96)

EXTERNAL

@hahewlet commented on this pull request.

In docs/CONFIG-VARS.mdhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsassoftware%2Fviya4-deployment%2Fpull%2F96%23discussion_r640912349&data=04%7C01%7Cthomas.pangborn%40sas.com%7Cdb9eb12090d94c2cc0c308d92146b030%7Cb1c14d5c362545b3a4309552373a0c2f%7C0%7C0%7C637577409756836038%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=A%2BHIb0%2FVES3b4OcNZ4kDGeFA1ShVC5VyKmh1NyejqCU%3D&reserved=0:

+| | | | | | | | +| INGRESS_NGINX_NAMESPACE | ingress-nginx helm install namespace | string | ingress-nginx | false | | baseline | +| INGRESS_NGINX_CHART_URL | ingress-nginx helm chart url | string | https://kubernetes.github.io/ingress-nginx | false | | baseline | +| INGRESS_NGINX_CHART_NAME | ingress-nginx helm chart name | string | ingress-nginx | false | | baseline | +| INGRESS_NGINX_CHART_VERSION | ingress-nginx helm chart version | string | 3.20.1| false | | baseline | +| INGRESS_NGINX_CONFIG | ingress-nginx helm values | string | see here | false | | baseline | +| | | | | | | | +| NFS_CLIENT_NAMESPACE | nfs-subdir-external-provisioner helm install namespace | string | nfs-client | false | | baseline | +| NFS_CLIENT_CHART_URL | nfs-subdir-external-provisioner helm chart url | string | https://kubernetes-sigs.github.io/nfs-subdir-external-provisioner/ | false | | baseline | +| NFS_CLIENT_CHART_NAME | nfs-subdir-external-provisioner helm chart name | string | nfs-subdir-external-provisioner | false | | baseline | +| NFS_CLIENT_CHART_VERSION | nfs-subdir-external-provisioner helm chart version | string | 4.0.8| false | | baseline | +| NFS_CLIENT_CONFIG | nfs-subdir-external-provisioner helm values | string | see here | false | | baseline | +| | | | | | | | +| METRICS_SERVER_CHART_URL | metrics-server helm chart url | string | https://charts.bitnami.com/bitnami/ | false | | baseline | +| METRICS_SERVER_CHART_NAME | metrics-server helm chart name | string | metrics-server | false | | baseline | +| METRICS_SERVER_CHART_VERSION | metrics-server helm chart version | string | 5.3.5 | false | | baseline |

This one seems a bit misleading. Two of our 3 cloud providers currently install a different version of the metric server, which is what we use. Can can we convey this here?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsassoftware%2Fviya4-deployment%2Fpull%2F96%23pullrequestreview-670567799&data=04%7C01%7Cthomas.pangborn%40sas.com%7Cdb9eb12090d94c2cc0c308d92146b030%7Cb1c14d5c362545b3a4309552373a0c2f%7C0%7C0%7C637577409756846298%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nfAYQ8ouY%2FN9Jfz7wKgZ0m1SDYdy3VYgP8ZJIAFso48%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHYCFOSP3K4PF3TE3SVQ27TTP2NK3ANCNFSM45TBJACA&data=04%7C01%7Cthomas.pangborn%40sas.com%7Cdb9eb12090d94c2cc0c308d92146b030%7Cb1c14d5c362545b3a4309552373a0c2f%7C0%7C0%7C637577409756846298%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6ZK21fc29eBKebTfacDbFTgjr3X0td81m%2F3XXGp3xvM%3D&reserved=0.