This project contains Terraform configuration files to provision infrastructure components required to deploy SAS Viya platform products on Microsoft Azure Cloud.
Apache License 2.0
72
stars
88
forks
source link
chore: (IAC-1196) Update path pattern to support additional branches #345
Updated the path pattern to support additional branches. Also noticed the child modules were not getting scanned for TFLint so updated the path and running it recursively.
On running TFLint recursively encountered a few errors and warnings which were resolved in this PR. Listing the errors below, changes to resolve the errors were made as per the TFLint recommendations.
~- Error: Invalid function argument~
~- Invalid value for "path" parameter: no file exists at "/.ssh/id_rsa.pub". We do not distribute this file as part of configuration code so setting the default path value returns error. Change was made similar to what we have in GCP. the files locals.tf, variables.tf and CONFIG-VARS.md were updated to resolve this error.~
terraform_unused_declarations
The unused variables aks_cluster_rg_id, create_netapp, vnet_name, private_dns_zone_id were removed.
terraform_deprecated_index
We were using the legacy form of splat expressions, which was updated to resolve the warning.
See the last commit on this PR for the three checks running successfully.
Changes:
Updated the path pattern to support additional branches. Also noticed the child modules were not getting scanned for TFLint so updated the path and running it recursively. On running TFLint recursively encountered a few errors and warnings which were resolved in this PR. Listing the errors below, changes to resolve the errors were made as per the TFLint recommendations. ~-
Error: Invalid function argument~ ~- Invalid value for "path" parameter: no file exists at "/.ssh/id_rsa.pub". We do not distribute this file as part of configuration code so setting the default path value returns error. Change was made similar to what we have in GCP. the fileslocals.tf,variables.tfandCONFIG-VARS.mdwere updated to resolve this error.~terraform_unused_declarationsaks_cluster_rg_id,create_netapp,vnet_name,private_dns_zone_idwere removed.terraform_deprecated_indexSee the last commit on this PR for the three checks running successfully.
Tests