search

sassoftware / viya4-iac-azure

This project contains Terraform configuration files to provision infrastructure components required to deploy SAS Viya platform products on Microsoft Azure Cloud.
Apache License 2.0
72 stars 88 forks source link

Add ZebClient in Direct mode deployment as storage type for viya4. #356

Closed alejovicu closed 7 months ago

alejovicu commented 8 months ago

This pr adds ZebClient as storage type

Usage example:

terraform apply  \
  --var-file examples/sample-input-zebclient-direct.tfvars \
  --var subscription_id=xxx-xxx-xxx-xxx-xxxx \
  --var tenant_id=xxx-xxx-xxx-xxx-xxx \
  --var zebclient_license_key=xxx-xxx-xxx-xxx-xxx-xxx \
  --var prefix=viya4-zcdirect \
  --var location=swedencentral \
  --var default_public_access_cidrs='["xxx.xxx.xxx.xxx/32"]'
riragh commented 7 months ago

Thank you for providing the code. An internal ticket IAC-1139 is open to investigate and integrate this feature when Zebware is available as an additional storage_type. Based on internal discussion the code here needs redesign to be uniform with other cloud providers, hence the changes here cannot be accepted to be merged. Closing this PR, upon reinvestigation and based on the priority for internal ticket a new PR will be created for this change.