search

sassoftware / viya4-iac-azure

This project contains Terraform configuration files to provision infrastructure components required to deploy SAS Viya platform products on Microsoft Azure Cloud.
Apache License 2.0
72 stars 88 forks source link

Feature Request: add kubelet_disk_type to compute node pools #363

Open Carus11 opened 7 months ago

Carus11 commented 7 months ago

We would like to use the kubernetes emptyDir volumes as the sas work location, and in order to utilise the local ephemeral ssd's on the compute nodes we need to specify kubelet_disk_type=Temporary https://registry.terraform.io/providers/hashicorp/azurerm/3.86.0/docs/resources/kubernetes_cluster_node_pool#kubelet_disk_type

This will put emptyDir on the temporary storage on the node, see https://learn.microsoft.com/en-us/samples/azure-samples/aks-ephemeral-os-disk/aks-ephemeral-os-disk/

When setting the value of [kubeletDiskType](https://github.com/Azure/azure-rest-api-specs/blob/5582a35deb1bfa4aa22bac8f1d51b7934ead94ac/specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2021-02-01/managedClusters.json#L3846-L3857) equal to Temporary, the operating system is hosted by the OS disk, no matter if the OS disk is managed or ephemeral, while container images, emptyDir volumes, and container logs are hosted by the temporary storage.

We are not allowed to use hostPath volumes. The requested property is available in the azurerm version used in this project, we just need the variable surfaced.

riragh commented 7 months ago

After internal discussions, a feature request ticket PMFR4PLTFND-96 was opened to add support for os_disk_type. The variable kubelet_disk_type can be added along with that.