This project contains Terraform configuration files to provision infrastructure components required to deploy SAS Viya platform products on Microsoft Azure Cloud.
Apache License 2.0
74
stars
89
forks
source link
fix: (IAC-1321) updates to create NSG in network rg #365
All network related resources should get created into a vnet resource group if supplied by user. VNET gets created correctly in network resource group if vnet_resource_group_name is provided however, NSG creation was not following the same pattern. This PR corrects that behavior to follow the same logic.
If vnet_resource_group_name is provided without nsg_name, IAC will create NSG for you in the provided vnet resource group else NSG will created in the AKS resource group like before.
fixes #328
Tests:
Verified following scenarios, see test details in internal ticket:
Changes:
All network related resources should get created into a vnet resource group if supplied by user. VNET gets created correctly in network resource group if
vnet_resource_group_nameis provided however, NSG creation was not following the same pattern. This PR corrects that behavior to follow the same logic.If
vnet_resource_group_nameis provided withoutnsg_name, IAC will create NSG for you in the provided vnet resource group else NSG will created in the AKS resource group like before.Tests:
vnet_resource_group_name = "rp-vnet-rg-t02"