search

sassoftware / viya4-iac-azure

This project contains Terraform configuration files to provision infrastructure components required to deploy SAS Viya platform products on Microsoft Azure Cloud.
Apache License 2.0
72 stars 88 forks source link

NSG gets created in Network Resource Group with no choice of creating in AKS resource group #384

Open stturc opened 3 months ago

stturc commented 3 months ago

Is your feature request related to a problem? Please describe.

We just began using the code change from #328 and it broke behavior we had been relying on. We had been specifying the vnet_resource_group_name, vnet_name, and subnet_names, but were not specifying nsg_name and wanted it created in the AKS recource group and not in our vnet_resource group. It doesn't look like there is now a way for us to specify where the creation of the NSG takes place.

Describe the solution you'd like

We would like to see an option to create the NSG into the AKS resource group.

Describe alternatives you've considered

No response

Additional context

No response

Code of Conduct

riragh commented 3 months ago

@stturc, after internal investigation and discussion it was identified that all the network resources should be grouped together, which was not the case with the NSG that was being created when user provided vnet_resource_group_name. Hence the change in PR #328. As this is the expected behavior, no further changes are expected. If you prefer to create the NSG in AKS resource group, I recommend you fork the repo and make the change here: https://github.com/sassoftware/viya4-iac-azure/blob/main/main.tf#L66 and specify resource_group_name = local.aks_rg.name.