sassoftware / viya4-iac-azure

This project contains Terraform configuration files to provision infrastructure components required to deploy SAS Viya platform products on Microsoft Azure Cloud.
Apache License 2.0
74 stars 89 forks source link

terraform plan returns Warning: Argument is deprecated - This property has been renamed to `authorized_ip_ranges` within the `api_server_access_profile` block #402

Closed spnmhb closed 2 weeks ago

spnmhb commented 1 month ago

Terraform Version Details

Tried with both latest 1.9.7 and suggested in https://github.com/sassoftware/viya4-iac-azure?tab=readme-ov-file#terraform-requirements 1.8.2

azureuser@viya-spnmhb-jump-vm:~/deploy/viya4/viya4-iac-azure/files/tools$ ./iac_tooling_version.sh { "terraform_version": "\"1.9.7\"", "terraform_revision": "null", "terraform_outdated": "false", "provider_selections": "{}" }

azureuser@viya-spnmhb-jump-vm:~/deploy/viya4/viya4-iac-azure/files/tools$ ./iac_tooling_version.sh { "terraform_version": "\"1.8.2\"", "terraform_revision": "null", "terraform_outdated": "true", "provider_selections": "{}" }

Terraform Variable File Details

tf_files.zip tf_files.zip contains terraform.tfvars and the main.tf mentioned in the warning obtained (also outputs.tf and variables.tf in the same directory)

Steps to Reproduce

Expected Behavior

Output with no warning or error messages

Actual Behavior

Additional Context

No response

References

No response

Code of Conduct

riragh commented 1 month ago

@spnmhb, this warning has been fixed in the major version of Terraform azurerm v4.0. We are consuming the new major version in the upcoming release. If you are interested please look at the PR #401. If this answers your question I would like to close this issue.

spnmhb commented 1 month ago

Thanks for the answer @riragh, that makes sense. So at this moment, for trying to make the terraform plan command work, would it be enough to update azurerm to v4.0 and then re-run terraform init plan / terraform plan? In that case, how can I manage to upgrade azurerm?

riragh commented 1 month ago

@spnmhb, no just updating the azurerm version to v4.0 will not be enough. This was breaking change from the provider so we had to make sure we updated all the pieces in our code correctly to consume the breaking changes. The changes are present in staging branch. We have not released the changes yet but at the moment if you want to use this new changes please pull "staging" branch and just run terraform plan.

spnmhb commented 1 month ago

@riragh Thank you very much for the answer. Just for information, is there an estimated date for the changes to be released?

riragh commented 2 weeks ago

The changes were released to main branch in v10.0.0.