This project contains Terraform scripts to provision cloud infrastructure resources, when using vSphere, and Ansible to apply the needed elements of a Kubernetes cluster that are required to deploy SAS Viya platform product offerings.
This was a majority of the code changes. Ansible recommends only using the "shell" module only when necessary and should be avoided unless there is a special need for using shell features, like environment variable expansion or chaining multiple commands using pipes.
The changes were just a simple drop in module replacement ansible.builtin.shell to ansible.builtin.command
We had warnings around a the include module that was going to be removed in ansible-core 2.16 and for reference we tell users to install Ansible 8.0.0 which comes packaged with ansible-core 2.15.0. So we are pretty close to the removal release.
Changes
Revisited the ansible-linter action to put in place code changes that required code/functionality changes rather than just formatting.
In particular the three warnings I addressed were:
command-instead-of-shell: https://ansible.readthedocs.io/projects/lint/rules/command-instead-of-shell/ansible.builtin.shelltoansible.builtin.commandcommand-instead-of-module: https://ansible.readthedocs.io/projects/lint/rules/command-instead-of-module/curlcalls were replaced withansible.builtin.get_urldeprecated-module: https://ansible.readthedocs.io/projects/lint/rules/deprecated-module/includemodule that was going to be removed in ansible-core 2.16 and for reference we tell users to install Ansible 8.0.0 which comes packaged with ansible-core 2.15.0. So we are pretty close to the removal release.import_tasks: https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.7.html#include-tasks-import-tasks-inline-variablesTests