search

sassoftware / viya4-iac-k8s

This project contains Terraform scripts to provision cloud infrastructure resources, when using vSphere, and Ansible to apply the needed elements of a Kubernetes cluster that are required to deploy SAS Viya platform product offerings.
Apache License 2.0
23 stars 15 forks source link

feat: (IAC-1187) Update METRICS_SERVER_CHART_VERSION default to 3.11.0 #99

Closed jarpat closed 6 months ago

jarpat commented 6 months ago

Changes

Update the default METRICS_SERVER_CHART_VERSION default to 3.11.0 to pull in fixes and improvements. This version is compatible with K8s 1.19+ https://github.com/kubernetes-sigs/metrics-server?tab=readme-ov-file#compatibility-matrix

Tests

Scenario Provider kubectl version cluster_version cluster_cni cluster_cni_version cluster_cri cluster_cri_version METRICS_SERVER_CHART_VERSION Order Cadence
1 OSS 1.27.9 1.26.12 calico 3.27.0 containerd 1.6.26 3.11.0 * fast:2020
2 OSS 1.27.9 1.27.9 calico 3.27.0 containerd 1.6.26 3.11.0 * fast:2020
3 OSS 1.27.9 1.28.5 calico 3.27.0 containerd 1.6.26 3.11.0 * fast:2020
dhoucgitter commented 6 months ago

@thpang , I think we intentionally removed the metrics-server APP_VERSION from our yaml a while ago since it had no bearing on the chart install and seemed confusing, however, wondering if our doc should say something about which app version of metrics-server is installed by default since that is not easy to tell on the surface?

thpang commented 6 months ago

Might be a good idea to reference like you said

jarpat commented 6 months ago

Might be a good idea to reference like you said

@dhoucgitter We did remove that appVersion in viya4-deployment where metrics server is installed specifically for AWS, however we never had the appVersion in this repo. However, I do agree that having an quick reference for users to figure out what appVersion the chart version translates to would be useful. In this repo the METRICSSERVER* variables are not documented but a user could change them if they come across it, in viya4-deployment it is exposed and present in the config-vars. I have another ticket to also make an update in that repo and will include a link for the user in the doc to determine the metrics server appVersion.

dhoucgitter commented 6 months ago

@jarpat , that sounds like it would be a helpful addition in both projects. Thanks for adding it.