search

sassoftware / viya4-monitoring-kubernetes

Provides simple scripts and customization options to deploy monitoring, alerts, and log aggregation for Viya 4 running on Kubernetes
Apache License 2.0
54 stars 32 forks source link

Move modified HpaMaxedOut alert to kube-prometheus-stack helm chart #580

Closed tynsh closed 10 months ago

tynsh commented 10 months ago

Currently the HpaMaxedOut alert from the default rules set of the kube-prometheus-stack helm chart is deployed and then modified on the cluster. More information on the current situation can be found in PR #575.

This PR moves the change to the values-prom-operator.yaml file so that users can modify the default set of alerts. The Alert is renamed to reflect the modification and avoid issues with the reused name during upgrades.

Fixes #575.

gsmith-sas commented 10 months ago

@tynsh Thank you for submitting this PR to address the problem you reported in #575. We will review the changes and do some testing/validation before merging it into the project. It is a short work here in the US due to a two-day holiday so we probably won't be able to do that until next week at the earliest. Thank you once again for taking the time to craft a fix and submitting it. Regards, Greg

tynsh commented 10 months ago

@gsmith-sas No problem, happy thanksgiving. Take your time :) Best, Tobias

gsmith-sas commented 10 months ago

We have approved this PR and merged the changes into our 'main' branch after validating it works as intended.

@tynsh Thank you for your contributions and (once again) making our project better!

gsmith-sas commented 10 months ago

@tynsh I just noticed that this Pull Request did not include the required contributor sign-off text. Unfortunately, I noticed this after merging the PR into the 'main' branch, so I had to revert (back out) the changes. Please open a new Pull Request with these same changes and include the contributor sign-off text. As a reminder, the contributor sign-off requires adding text like the following to the DESCRIPTION field of the Pull Request when you open it.

    Signed-off-by: Random J Developer <random@developer.example.org>

It would also be helpful if you included an entry in the CHANGELOG.md file describing the change in the PR. Here is the CHANGELOG.md entry I created for your original PR:

unreleased

I apologize for not catching this earlier and having to ask you to submit a new PR for this.

Regards, Greg

tynsh commented 9 months ago

@gsmith-sas Hi Greg, thanks for the response. Right, I forgot the sign-off. It'll take me until mid next week to get back to this, but I'll send a PR :)

gsmith-sas commented 9 months ago

@tynsh Thanks. And, as a wise man once said: "Take your time :)".