search

sassoftware / viya4-orders-cli

A CLI that calls the appropriate SAS Viya Orders API endpoint to obtain the requested Viya software order assets for the given order.
Apache License 2.0
14 stars 6 forks source link

added note after discussion with Technical Support #21

Open zencircle opened 2 years ago

sarahcpage commented 2 years ago

Hi - thank you for your pull request. I'm not in agreement with putting information about another project (https://github.com/sassoftware/viya4-deployment) in this project's README - I believe that the note belong's in the https://github.com/sassoftware/viya4-deployment project README. Can you explain your reasoning for wanting to add it here?

zencircle commented 2 years ago

Hi - thank you for your pull request. I'm not in agreement with putting information about another project (https://github.com/sassoftware/viya4-deployment) in this project's README - I believe that the note belong's in the https://github.com/sassoftware/viya4-deployment project README. Can you explain your reasoning for wanting to add it here?

viya4-deployment points to viya4-orders-cli to retrieve the deployment assets, hence I added here

sarahcpage commented 2 years ago

Hi - thank you for your pull request. I'm not in agreement with putting information about another project (https://github.com/sassoftware/viya4-deployment) in this project's README - I believe that the note belong's in the https://github.com/sassoftware/viya4-deployment project README. Can you explain your reasoning for wanting to add it here?

viya4-deployment points to viya4-orders-cli to retrieve the deployment assets, hence I added here

Why not put the note in the viya4-deployment project README? In this project's README you could add a note to say that this tool only works with a Viya 4 2020.+ order (and not the trial) if you want.

zencircle commented 2 years ago

Hi - thank you for your pull request. I'm not in agreement with putting information about another project (https://github.com/sassoftware/viya4-deployment) in this project's README - I believe that the note belong's in the https://github.com/sassoftware/viya4-deployment project README. Can you explain your reasoning for wanting to add it here?

viya4-deployment points to viya4-orders-cli to retrieve the deployment assets, hence I added here

Why not put the note in the viya4-deployment project README? In this project's README you could add a note to say that this tool only works with a Viya 4 2020.+ order (and not the trial) if you want.

Downloading assets is not part of viya-deployment package its part of viya4-orders-cli, I will create issue on viya4-deployment repo and get thoughts for the developers