sassoftware / vscode-sas-extension

This SAS Extension for Visual Studio Code provides support for the SAS language, including features such as SAS syntax highlighting, code completion, hover help, code folding, outline, SAS code snippets and run SAS code.
https://sassoftware.github.io/vscode-sas-extension/
Apache License 2.0
117 stars 47 forks source link

Support Recycle Bin in the Content Pane #152

Closed boyce-w closed 1 year ago

boyce-w commented 1 year ago

Is your feature request related to a problem? Please describe. This is split from #109 : File deletion: Right now, deleting a file permanently deletes it from SAS. In this issue, we'll want to implement the Recycle Bin functionality that is currently part of SAS drive (look for TODO #109 in the project's code)

Describe the solution you'd like

Environment SAS Viya

Zhirong2022 commented 1 year ago

@skyeaussie , @crlewi Could you take some time on your convenience to check the concerns below? Some concerns towards the file/folder in Recyble bin folder.

  1. Is it neccessary to prompt some sort of message dialog to ask the user to confirm the delete action if trying to delete a file/folder?
  2. Is it neccessry to ask the user to confirm 'Empty Recycle Bin' ?
crlewi commented 1 year ago

@Zhirong2022

  1. Deleting files or folders from the content tree does not need a confirmation
  2. Permanently deleting items from the recycle bin should have confirmation messages.

A. Single item selected warning dialog with title of "Delete" and Delete and Cancel buttons: Are you sure you want to permanently delete the item ""?

B. Multiple items selected warning dialog with title of "Delete" and Delete and Cancel buttons: Are you sure you want to permanently delete the selected items?

C. Empty recycle bin warning dialog with title of "Empty Recycle Bin" and Delete and Cancel buttons: Are you sure you want to permanently delete all the items? You cannot undo this action.

boyce-w commented 1 year ago

fix pushed and close this feature