search

sassoftware / vscode-sas-extension

This SAS Extension for Visual Studio Code provides support for the SAS language, including features such as SAS syntax highlighting, code completion, hover help, code folding, outline, SAS code snippets and run SAS code.
https://sassoftware.github.io/vscode-sas-extension/
Apache License 2.0
117 stars 47 forks source link

Invalid endpoint error if the pre-created valid profile has no connectionType #157

Closed Zhirong2022 closed 1 year ago

Zhirong2022 commented 1 year ago

Describe the bug Install the SAS extension package generated base on the main branch. Change profile to a valid one created before, try to Run SAS code, 'Invalid endpoint' error happened.

Steps to reproduce Steps to reproduce the behavior:

  1. Change profile to a pre-created one which has no connection type
  2. Run SAS Code

Expected behavior The error make sense or connnectionType can be added automatically for the profiles already created before

Screenshots image

smorrisj commented 1 year ago

Thanks @Zhirong2022. This issue is related to #151. There is code added to extension activation event to migrate over the legacy profile to add connectionType of "rest" so that the profiles that existed before the ssh update are properly treated as viya connections. There is also a fix to make the error message more intuitive to what's going on if a profile is encountered with an unsupported connectionType value.

smorrisj commented 1 year ago

Fixed on #188

smorrisj commented 1 year ago

@Zhirong2022 The fix has been merged to main. I was wondering if you could verify?

Zhirong2022 commented 1 year ago

@smorrisj Thank you for your update. The issue has been fixed in the latest main branch.

smorrisj commented 1 year ago

Thanks @Zhirong2022. If its agreeable can you put the testing-complete label? Once that happens I'll close out.

smorrisj commented 1 year ago

Thanks @Zhirong2022. If its agreeable can you put the testing-complete label? Once that happens I'll close out.