search

sassoftware / vscode-sas-extension

This SAS Extension for Visual Studio Code provides support for the SAS language, including features such as SAS syntax highlighting, code completion, hover help, code folding, outline, SAS code snippets and run SAS code.
https://sassoftware.github.io/vscode-sas-extension/
Apache License 2.0
121 stars 48 forks source link

add APPNAME when starting a SAS 9.4 IOM connection #762

Open brunomueller opened 10 months ago

brunomueller commented 10 months ago

Is your feature request related to a problem? Please describe. Looking at the log file of the Object Spawner we see the following:

2024-01-17T14:29:12,910 INFO [00000105] :sasdemo - New client connection (20) accepted from server port 8591 for user sasdemo. ... :56408 for APPNAME=SAS Data Integration Studio.

2024-01-17T14:33:34,293 INFO [00000130] :sasdemo - New client connection (22) accepted from server port 8591 for user sasdemo. ... :56800.

2024-01-17T14:38:32,804 INFO [00000173] :sasdemo - New client connection (26) accepted from server port 8591 for user sasdemo. ... :61221 for APPNAME=SAS Enterprise Guide.

The first line is the request to start a workspace server from SAS Data Integration Studio The second line is the request to start a workspace server from the SAS VSCode extension The third line is the request to start a workspace server from SAS Enterprise Guide

Describe the solution you'd like Would be great to see an APPNAME= as well when starting a workspace server from VSCode

This will help anyone analysing Object Spawner log files

Environment SAS version: SAS9.4 M8 SAS Extension for VSCode: 1.6.0

DominiqueLatour commented 9 months ago

I am currently working with Ralph Abbey and Xin Hunt on PROC REGISTERMODEL to register models to Model Manager. That will enable users to register models from workbench and SAS Studio. One of the requirements is to have the environment the model was created. For example, when submitting code form SAS Studio, the following macros are initialized by SAS Studio:
%let _clientapp = %nrquote(%nrstr(SAS Studio)); %let _clientappabbrev = %nrquote(%nrstr(Studio)); %let _clientappversion=2020;

This enables us to fetch that information. It would be great that in the VS Code plug for workbench to have similar macros to enable use to retrieve that we are in "VS Code SAS" and have the version.

Casey Smith told me that Bruno had already entered a similar request although not specific to workbench

snlwih commented 9 months ago

@DominiqueLatour, sounds to me that what you describe is slighly different from what Bruno is asking for.

Bruno is just asking for providing client info on the request that initiates a server connection, so the object spawner log shows which client requested a server session. When I interpret your suggestions correctly, you are asking for client-generated macro variables that represent the name of the client application and its version number, so you can take advantage of that information in the SAS code you are submitting.

Could you please create a dedicated GitHub Issue for this, so we can track this easier going forward? Once you have created it, we will add a link to it in this comment thread.

snlwih commented 9 months ago

@brunomueller, am I correct in saying that SAS applications like SAS Data Integration Studio and SAS Enterprise Guide only provide their appname and no version information on the request? Just double-checking.

brunomueller commented 9 months ago

@snlwih yes the APPNAME= only contains the application name, see the very first entry.