sasstools / gulp-sass-lint

Gulp plugin for Sass Lint
MIT License
115 stars 43 forks source link

@charset must be wrapped with double quotes #82

Closed leymannx closed 7 years ago

leymannx commented 7 years ago

v1.3.3

Same as here: https://github.com/brigade/scss-lint/issues/781

Linter gives warning on double quotes with charset: @charset "UTF-8";

1:10 warning Strings must use single quotes quotes

But for backward compatibility it must be written with double quotes: https://www.w3.org/TR/css-syntax-3/#charset-rule

Therefore, an @charset rule may appear in the object model even if it was ignored by that algorithm. (For instance, if it was written with extra whitespace or with single rather than double quotes.)

So I guess we need an exception for this.

Refs https://github.com/HugoGiraudel/sass-guidelines/issues/255

leymannx commented 7 years ago

Ah, I guess it's an issue for https://github.com/sasstools/sass-lint then, right?

leymannx commented 7 years ago

Ah, it already exists over there https://github.com/sasstools/sass-lint/issues/1004.

So, yeah. I guess I can close this issue again :)