sasstools / scss-tokenizer

A tokenzier for Sass' SCSS syntax
MIT License
24 stars 22 forks source link

Index.js is missing #12

Closed gianpietro1 closed 7 years ago

gianpietro1 commented 7 years ago

Hi,

Not sure why, my environment has been pulling a scss-tokenizer version without an index.js file, so I've had to manually generate it every time.

It's been called by saas-graph 2.1.1, which package.json file says: ""scss-tokenizer": "^0.2.1""

Details of my environment (I know it's kind of old, but it's an application requirement):

Regards, Gianpietro

xzyfer commented 7 years ago

This might be related to your old version of npm. Not sure why exactly or how to fix it. I'll need to investigate.

On 3 May 2017 4:16 am, "Gianpietro Lavado" notifications@github.com wrote:

Hi,

Not sure why, my environment has been pulling a scss-tokenizer version without an index.js file, so I've had to manually generate it every time.

It's been called by saas-graph 2.1.1, which package.json file says: ""scss-tokenizer": "^0.2.1""

Details of my environment (I know it's kind of old, but it's an application requirement):

  • Ubuntu Trusty 14.04.4
  • Node version 0.10.25
  • NPM version 1.3.10

Regards, Gianpietro

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sasstools/scss-tokenizer/issues/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjZWJCuK45GK3-RaIAi73HqT1oC5ZxDks5r1-NygaJpZM4NO5PA .

jfridye commented 7 years ago

Thanks for checking into this.

I'm seeing a similar error with npm v0.10.38. This started within the past few days. We have sass-graph@2.2.2 which depends on scss-tokenizer@0.2.1.

xzyfer commented 7 years ago

That's a node version not an npm version. Node 0.10 and npm 1 are end of lifed so I'm not sure if there's anything we can do but I'll try to reproduce it locally.

feraudet commented 7 years ago

+1

rasta-rocket commented 7 years ago

+1

xzyfer commented 7 years ago

Can you all please confirm your node and npm versions?

rasta-rocket commented 7 years ago

npm version 1.3.10 node version v0.10.25

jfridye commented 7 years ago

npm 1.4.28 node v0.10.38

xzyfer commented 7 years ago

I have not been able to reproduce this locally with

➔ node -v
v0.10.48
➔ npm -v
1.4.29

Could y'all please show the output of listing the files in scss-tokenizer directory?

ls -lsa node_modules/node-sass/node_modules/sass-graph/node_modules/scss-tokenizer

* the path may be different on your system.

Also please try downloading the tarball directly and confirming the index.js is there. You can find the tarball by running

npm v scss-tokenizer

The end of the output should how the tarball url

  dist:
   { shasum: '07c0cc577bb7ab4d08fd900185adbf4bc844141d',
     tarball: 'https://registry.npmjs.org/scss-tokenizer/-/scss-tokenizer-0.2.1.tgz' },
rasta-rocket commented 7 years ago
$ npm install node-sass
  ...

$ ls -lsa node_modules/node-sass/node_modules/sass-graph/node_modules/scss-tokenizer
total 24
4 drwxrwxr-x 4 user group 4096 May 12 09:53 .
4 drwxrwxr-x 5 user group 4096 May 12 09:53 ..
4 drwxr-xr-x 2 user group 4096 May 12 09:53 lib
4 drwxrwxr-x 4 user group 4096 May 12 09:53 node_modules
4 -rw-r--r-- 1 user group 2387 May 12 09:53 package.json
4 -rw-r--r-- 1 user group 1238 Jan 29 04:58 README.md

$ npm v scss-tokenizer | tail
dist: 
   { shasum: '07c0cc577bb7ab4d08fd900185adbf4bc844141d',
     tarball: 'https://registry.npmjs.org/scss-tokenizer/-/scss-tokenizer-0.2.1.tgz' },

$ wget https://registry.npmjs.org/scss-tokenizer/-/scss-tokenizer-0.2.1.tgz
--2017-05-12 13:13:14--  https://registry.npmjs.org/scss-tokenizer/-/scss-tokenizer-0.2.1.tgz
Resolving registry.npmjs.org (registry.npmjs.org)... 151.101.120.162
Connecting to registry.npmjs.org (registry.npmjs.org)|151.101.120.162|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 5777 (5.6K) [application/octet-stream]
Saving to: ‘scss-tokenizer-0.2.1.tgz’

100%[================================================================================================================================================================================================>] 5,777       --.-K/s   in 0s      

2017-05-12 13:13:14 (70.0 MB/s) - ‘scss-tokenizer-0.2.1.tgz’ saved [5777/5777]

$ tar -xzf scss-tokenizer-0.2.1.tgz

$ ls package/
total 20
-rw-r--r-- 1 user group   49 Apr 29 01:52 index.js
drwxrwxr-x 2 user group 4096 May 12 13:13 lib
-rw-r--r-- 1 user group 1077 Jan 28 11:17 LICENSE
-rw-r--r-- 1 user group  963 Apr 29 02:14 package.json
-rw-r--r-- 1 user group 1238 Jan 29 04:58 README.md

Also I would like to add a remark, even when I npm install scss-tokenizer there is no index.js and src directory

xzyfer commented 7 years ago

Thanks @rasta-rocket, this is fascinating.

xzyfer commented 7 years ago

Ok I've been able to reproduce this with

➔ node -v
v0.10.25
➔ npm -v
1.3.10

After some npm version bisecting I have been able to reproduce this issue up until npm@1.4.0 but not after. This conflicts with the information provided by @jfridye.

I'm going to investigate some potential workarounds

xzyfer commented 7 years ago

I believe this is resolved in v0.2.3. Please confirm.

rasta-rocket commented 7 years ago

Also I tested the 0.2.0 version, the index.js is present

xzyfer commented 7 years ago

Fixed in d84958c

rasta-rocket commented 7 years ago

Thx. Do you will update the new version on sass-graph package.json ?

xzyfer commented 7 years ago

Published sass-graph@2.2.3