search

sasstools / scss-tokenizer

A tokenzier for Sass' SCSS syntax
MIT License
24 stars 22 forks source link

Source map 0 7 x #16

Closed akkumar closed 6 years ago

akkumar commented 6 years ago

Upgrade source-map to 0.7.x as needed by downstream projects

akkumar commented 6 years ago

@xzyfer - FYI . amended commit here without package-lock.json . Let me know how it looks though.

important: this does break backward compatibility with node.js pre-6 . FYI . Let me know if that would be ok though.

xzyfer commented 6 years ago

We would need to bump the major to merge this. Can you please elaborate on what issues the current version is causing for people?

akkumar commented 6 years ago

Since source-map 0.6.0+ , the typings are distributed (.d.ts) within source-map package . Previously a separate types/source-map is explicitly necessary that has been deprecated since (after source-map 0.6.0 that is).

FYI more here on - https://github.com/angular/devkit/pull/452 - the bazel build had to be upgraded to depend on source-map 0.7.x .

akkumar commented 6 years ago

If we want to bump to a major version, do we need a separate branch for 0.x to continue with minor versions and releases , while this can go to master for the major version ?

akkumar commented 6 years ago

@xzyfer - major version bumped up given the nature of the changes involving deprecating node<6.

akkumar commented 6 years ago

@xzyfer - what would you suggest to take this one up - a separate branch ?