search

satRdays / badgeR

badgeR R package
1 stars 3 forks source link

Extra field #12

Closed dokato closed 4 years ago

dokato commented 4 years ago

There is a new optional field below the role, called "extra". Should fix #5 .

DaveParr commented 4 years ago

I think the concept is good, and happy to have satRdays be a default.

Just pulled down this branch and as the wd at that point is set to /badgeR and the file is in the examples folder could I suggest we either do a super-basic change to "examples/satrdays_logo.png" to prevent the user having to setwd() or equivalent, or a slightly more robust change where this file is accessible from the package as a data object before we do the merge?

IMHO the example should run simply no matter where the wd is set at that point.

dokato commented 4 years ago

@DaveParr agreed with the last point and although I wasn't entirely sure how to add logo as the package data, I solved it by moving it to inst/ and calling system.file. Now it should work regardless of the path after installing the package.