search

satRdays / hugo-satrdays-theme

theme for satRdays conference websites
Apache License 2.0
8 stars 7 forks source link

Include all the missing assets from hugo-agency-theme #37

Closed DaveParr closed 4 years ago

DaveParr commented 4 years ago

This work migrates all the remaining assets from hugo-agency-theme to this theme, as hugo-agency-theme is now achived. I understand this to be allowed by the Apache 2.0 license and encouraged behaviour when a repo archived. If anyone knows otherwise/ the original coders ( @digitalcraftsman + @stp-ip )have an issue with this, please let me know and we'll do whatever you need to make this 'correct'.

The intent for future work is to re-organise the partials that I have missused into a far more sane naming convention, and to continue building from them.

@RMHogervorst I've pinned you as a reviewer for a sanity check as you so kindly helped identify the missing partials. Feel free to decline though, I know we all have lives outside of GitHub +1

Closes #25 #24 #23

Sorry for the previous #35 I had a brain-fart and tried to merge into develop which not having develop be updated to where master was and it was all just a mess. I hope unless GH decides to pull shenanigans this will be a cleaner review.

digitalcraftsman commented 4 years ago

Hello Dave,

I don't have any issues with your plans. It is great to see that there is still interest in the theme and that it will be further developed in some form. And I don't see any roadblockers made by the Apache license either. So feel free to proceed.

stp-ip commented 4 years ago

+1

DaveParr commented 4 years ago

@digitalcraftsman @stp-ip thanks both. Your work was foundational to getting this project bootstrapped into a useful codebase. We're really grateful for your contribution to OS. So far this theme has powered approximately 20 conferences around the world :)