search

satRdays / satRday_site_template

Templates and partials for generating a site for a specific satRday conference
https://satrdays-event-template.netlify.com/
MIT License
1 stars 9 forks source link

Remove hugo-agency-theme from config #30

Closed jdblischak closed 3 years ago

jdblischak commented 3 years ago

Follow up to #20. I couldn't build the site with hugo serve until I removed hugo-agency-theme from config.toml.

$ hugo version
Hugo Static Site Generator v0.72.0-8A7EF3CF/extended linux/amd64 BuildDate: 2020-05-31T12:14:23Z
DaveParr commented 3 years ago

@jdblischak thanks for this PR. You are probably right that this needs doing. I think I messed up somewhere around #28 and #27 at the tail end of hacktoberfest. I'll try and work out the best way to solve this problem taking the history into account to make sure that the intended changes from hacktoberfest are in the current master build.

jdblischak commented 3 years ago

This appears to have been fixed on the branches "develop" and "main" but not "master". It's unclear to me which branches are currently supported and which are deprecated. @DaveParr should we close this PR?

DaveParr commented 3 years ago

@jdblischak sorry for the confusion, as you pointed out in #19 I should have deleted master, and yes, main is the current production branch. As a result this PR doesn't have a target anymore and GitHub automatically closed it. I'd like to have 'develop' as the target for new PRs though, so it is now set as the default branch for future PRs. As you can see here: https://github.com/satRdays/satRday_site_template/blob/663e39f8e2a2ade0aac3c38d2062b05186177acf/config.toml#L5

Due to the way I created Main, this issue is not a problem on that branch, so this PR isn't required, though I'm very grateful for your PR which raised it to my attention and for your continued contributions to the project :)