search

satRdays / satRday_site_template

Templates and partials for generating a site for a specific satRday conference
https://satrdays-event-template.netlify.com/
MIT License
1 stars 9 forks source link

Fix modalIDs #33

Closed jdblischak closed 2 years ago

jdblischak commented 3 years ago

The modalID's don't work properly if they aren't nested beneath [talk_details].

I made my changes on top of the branch "main" since was the branch most recently committed to.

DaveParr commented 3 years ago

Thanks or the PR @jdblischak , Could you explain a little bit about what 'doesn't wor' about the modalIDs?

Not suggesting your wrong, I'm just not understanding what the problem is this PR is solving :)

jdblischak commented 3 years ago

Could you explain a little bit about what 'doesn't wor' about the modalIDs?

If modalID is defined above [talk_details] instead of below it, when you click on the talk, it displays #portfolioModal for every single talk. The result is that the modal that gets shown is always the one for the first talk.

When modalID is defined below [talk_details], it displays #portfolioModal<modalID>, and thus the modal for each talk corresponds to the details of that talk.

I figured out how to solve it by looking at the formatting of the talk yaml files for SatRday Nairobi. To see for yourself, you could clone their repo and then move some of the modalIDs to be above [talk_details].