jamie-wearsafe
commented
3 years ago as in at this part of the code change it to this:
import * as exec from 'actions-exec-listener'
import * as core from '@actions/core'
export class ImageDetector {
async getExistingImages(): Promise<string[]> {
const _filter = core.getInput(`filter`)
const filter = _filter ? `--filter=${_filter}` : ''
const existingSet = new Set<string>([])
const ids = (await exec.exec(`docker image ls -q ${filter}`, [], { silent: true, listeners: { stderr: console.warn }})).stdoutStr.split(`\n`).filter(id => id !== ``)
const repotags = (await exec.exec(`docker`, `image ls --format {{.Repository}}:{{.Tag}} ${filter} --filter=dangling=false`.split(' '), { silent: true, listeners: { stderr: console.warn }})).stdoutStr.split(`\n`).filter(id => id !== ``);
core.debug(JSON.stringify({ log: "getExistingImages", ids, repotags }));
([...ids, ...repotags]).forEach(image => existingSet.add(image))
core.debug(JSON.stringify({ existingSet }))
return Array.from(existingSet)
}
async getImagesShouldSave(alreadRegisteredImages: string[]): Promise<string[]> {
const resultSet = new Set(await this.getExistingImages())
alreadRegisteredImages.forEach(image => resultSet.delete(image))
return Array.from(resultSet)
}
}
leigh-hobbii
MostefaKamalLala
cb109
madhavajay
jsirianni
Is your feature request related to a problem? Please describe. Not all images need caching, and can take up valuable room. Some images are loaded before the cache is loaded such as the images in services. So excluding those images would help reduce the size and speed up the save/load process.
Describe the solution you'd like When doing
docker save $(docker images -q)you can provide a list of the image ID's to save. If we could provide a filter at that point, it would mean we were only saving the images that we needed and so instead of this list:A filter would be added at this point:
and we would get this list instead: