satanasov / postlove

The Post love extension fo PhpBB 3.1
GNU General Public License v2.0
30 stars 32 forks source link

Support for Comboot #27

Open vico93 opened 8 years ago

vico93 commented 8 years ago

Hi all!

Just wonder if you guys would consider adding style files specifically for Comboot, a style made entirely using Bootstrap 3 (and its icons by Glyphicons and Font Awesome).

I asked this because, unlike other styles, Comboot is deeply different than prosilver in code and layout structure. In fact, it perform better on mobile than the original prosilver.

Here is the repo link. Sadly @TheZoker (the author) wants privacy until he releases the first public version (anyway the theme is already well stable), but access can be easily given via this page (entering github email is enough).

I consider make that compatibility myself, but i actually have no time.

I think it can be release natively within this repo, or made in a compatibility pack format (which can be free :smile: or paid :cry: )

Anyway, thanks for reading!

satanasov commented 8 years ago

I could probably write such a theme ... I will need the beta version thou ...

vico93 commented 8 years ago

As far i can tell, you need to "subscribe" in this page to have access to the repo... @TheZoker what can you say about?

satanasov commented 8 years ago

I have subscribed and I have access to the theme ... I will try working with the beta tonight.

TheZoker commented 8 years ago

@satanasov Ok great, let me know, if you need any support :)

satanasov commented 8 years ago

If you have all style events, it will be ok.

TheZoker commented 8 years ago

Yes ComBoot includes all events listed here: https://wiki.phpbb.com/Event_List#Template_Events

satanasov commented 8 years ago

Perfect ... if not tonight or tomorrow's night I'll make the conversion.

satanasov commented 8 years ago

A quick question - how should the template name be - ComBoot or comboot ? And how can I create a compatibility pack?

And it is basically done!

TheZoker commented 8 years ago

Please name it comboot, as described in this entry: https://comboot.io/blog/support/kb/create-compatibility-pack/

TheZoker commented 8 years ago

Do you have a package ready, so I can test it?

satanasov commented 8 years ago

Not for the moment - Friday probably ...

JacobOre commented 8 years ago

Any updates, would love to use this extension with comboot?

satanasov commented 8 years ago

I will submit it for test soon (it's done but I have some other stuff to do).

satanasov commented 8 years ago

So I think I have submitted it ...

TheZoker commented 8 years ago

Yes i received it :) I will check it today

vico93 commented 8 years ago

Before i close the issue, @TheZoker , where are the pack @satanasov made on the download page? i just see your (paid) packs and Board Rules, OneAll and QuickReply on 3rd party (free) section.

JacobOre commented 8 years ago

Any updates?

TheZoker commented 8 years ago

Will make it available tomorrow

TheZoker commented 8 years ago

@satanasov Did you see my commit?

JacobOre commented 8 years ago

..?

satanasov commented 8 years ago

By some strange reason I wasn't notified. I'll accept it.

JacobOre commented 8 years ago

Where can I find the extension for Comboot?

satanasov commented 8 years ago

I don't understand the question.

JacobOre commented 8 years ago

Well, where do I download the extension that has support for ComBoot?

satanasov commented 8 years ago

This repo?

vico93 commented 8 years ago

He says about the files for Comboot support. I didnt find any 'comboot' folder in "styles" folder. Do you make a compatibility pack?

TheZoker commented 8 years ago

@satanasov Sadly, the extensions does not 100% work with the "comboot-way-change". Can you please have a look? I guess it's a issue with your javascript, which I can not change, because its not in the theme folder. I would also suggest, that you use fontawesome instead of the heart image. phpBB will add support for fontawesome in 3.2, so it's a good time to add it. What do you think?

@vpontin I did not release it yet, because it does not 100% work (as described above). If you want to download it, you have to go to the "comboot" branche: https://github.com/satanasov/postlove/tree/comboot

JacobOre commented 8 years ago

Thanks for the update; much appreciated.

vico93 commented 8 years ago

@TheZoker oh thanks for make me knows, i'm a noob in GIT rules, so i didint notice the branches