satazor / js-spark-md5

Lightning fast normal and incremental md5 for javascript
Do What The F*ck You Want To Public License
2.46k stars 470 forks source link

Fix IE11 performance issue. #41

Closed nochev closed 7 years ago

nochev commented 7 years ago

With these changes md5cycle works around 5x faster in IE. Referenced from this issue and this project.

satazor commented 7 years ago

This looks good, thanks for your work @nochev. Could you create a comparison in http://jsperf.com/ so that we can see the perf on IE as well as other browsers?

nochev commented 7 years ago

I created two performance tests: normal and incremental.

Browser Test Ops/sec
IE 11 Non-optimized Normal 1.14 ±0.41% 73% slower
IE 11 Optimized Normal 4.27 ±0.74% fastest
IE 11 Non-optimized Incremental 1.10 ±0.50% 68% slower
IE 11 Optimized Incremental 3.60 ±3.79% fastest
Chrome Non-optimized Normal 4.35 ±0.87% 24% slower
Chrome Optimized Normal 5.71 ±0.42% fastest
Chrome Non-optimized Incremental 3.26 ±5.38% 22% slower
Chrome Optimized Incremental 4.06 ±1.82% fastest
Firefox Non-optimized Normal 3.00 ±10.14% fastest
Firefox Optimized Normal 3.00 ±5.92% fastest
Firefox Non-optimized Incremental 2.85 ±2.54% 3% slower
Firefox Optimized Incremental 2.90 ±1.22% fastest
satazor commented 7 years ago

This looks great! Thank you for your hard work!