fix(toUTF8): replace deprecated unescape with decodedURIComponent

satazor / js-spark-md5

Lightning fast normal and incremental md5 for javascript

Do What The F*ck You Want To Public License

2.49k stars 467 forks source link

fix(toUTF8): replace deprecated unescape with decodedURIComponent #66

Open cachelina opened 1 year ago

cachelina commented 1 year ago

This PR updates the toUTF8 function to use decodedURIComponent, instead of the deprecated unescape as suggested here MDN.

satazor commented 1 year ago

Hey! The changes in this PR are giving wrong md5 results unfortunately. :/

cachelina commented 1 year ago

Hey! The changes in this PR are giving wrong md5 results unfortunately. :/

Hey! I’ll take a look at this again :) I thought decodeURIComponent had the correct encodings to begin with, and that’s why I updated the tests.

cachelina commented 1 year ago

Hey @satazor I just pushed up some changes. Specifically, I reimplemented the native unescape from V8. I noticed there were a few functions responsible for converting characters to hex in the codebase.

However, I wasn't sure which one would accomplish what I needed, so I ported the hexing function from V8. Let me know your thoughts 🙂