Open NicBright opened 1 year ago
Hello, you can take a look at this package. It is a copy for spark-md5.js
which Provide ESM.
import SparkMD5, { md5, md5Sum } from 'https://unpkg.com/crypto.web.js@1.0.0/dist/md5.js'
I have the same request as @NicBright. I just checked @yutent suggestion, but the package’s README is in chinese, and the corresponding github repo was deleted (seems like the author wasn't happy with Github enforcing 2FA…). So this is not an option for me. While I was searching for an ESM solution, I found md5-es package, but it doesn't provide incremental usage as sparkMD5 does (which is the feature we're using on our code). So I still fill like an official sparkMD5 ESM version would be nice.
I have the same request as @NicBright. I just checked @yutent suggestion, but the package’s README is in chinese, and the corresponding github repo was deleted (seems like the author wasn't happy with Github enforcing 2FA…). So this is not an option for me. While I was searching for an ESM solution, I found md5-es package, but it doesn't provide incremental usage as sparkMD5 does (which is the feature we're using on our code). So I still fill like an official sparkMD5 ESM version would be nice.
the repo is here, and just add an English Readme
.
the repo is here, and just add an
English Readme
.
thanks !
Just to point out that there is fork of js-spark-md5 that just changes what needs to be changed to make it ESM:
The diff is actually minimal: https://github.com/satazor/js-spark-md5/compare/master...scx567888:js-spark-md5-es:master
You don't even have to change your imports if you alias the package in your package.json:
"dependencies": {
"spark-md5": "npm:spark-md5-es@3.0.2"
},
"devDependencies": {
"@types/spark-md5": "3.0.4"
}
I use PNPM, but I figure aliasing is the same in NPM and Yarn, or at least similiar.
Hi there
I wonder whether it would be possible for you to provide an ESM compatible build ... ? Why? It's all about the shift of going from
require()
toimport / export
style syntax ...My special use case is this: I'm migrating our code base's unit tests (Jest) to ESM modules, see https://jestjs.io/docs/ecmascript-modules For this to work, however, the packages need to conform to new ESM modules standards. For example, Jest will fail when it encounters old CommonJS style
require()
calls. In the case ofspark-md5
, it is not even possible (for me) to add it to Jest'stransformIgnorePatterns
(and have it be re-compiled) because (I'm not an UMD expert) it seems to me that the generated UMD file (spark-md5.js
) is malformed. So for now I have to copy the whole source code ofspark-md5
directly into my code base (in ESM module compatible way) as a workaround.The new
exports
property in package.json helps with providing builds delivering modern ESM modules. Being backwards-compatible with old Node.js versions at the same time is easy because old Node.js versions will ignore theexports
property and keep referring to package.json'smain
property instead (so you can still provide a CommonJS build and point to it viamain
property). If you don't know the newexports
property, I recommend a short read of the following resources:Best Regards, Nicolas