search

satbyy / go-noto-universal

Noto fonts go universal! Download pan-Unicode, merged Noto fonts according to time of usage (current, ancient) or geographical region (South Asia, SE Asia, Africa-MiddleEast, Europe-Americas).
Other
157 stars 22 forks source link

Add Noto Music #19

Closed satbyy closed 2 years ago

satbyy commented 2 years ago

It seems that the Musical Symbols (U+1D100 - U+1D1FF) block is already included in Noto Symbols 2 font, which has been merged for "Go Noto Contemporary". So the "Noto Music" font brings in Byzantine Musical Symbols and Ancient Greek musical symbols -- both of which are historical and not needed for this purpose.

So we don't need this PR at all.

dscorbett commented 2 years ago

What do you mean? Noto Sans Symbols2 doesn’t cover the Musical Symbols block.

satbyy commented 2 years ago

What do you mean? Noto Sans Symbols2 doesn’t cover the Musical Symbols block.

My bad. I looked at the wrong font. You're right that it doesn't cover Musical symbols.

Anyway, so, after adding Noto Music, I hit the same error with "GSUB" overflow as before. Hence, I trimmed the Tibetan subset even further (please check PR code change). This works for now, but I don't know Tibetan well. Please suggest a better way if you know!

satbyy commented 2 years ago

Maybe Tibetan is the wrong one to optimize. Much of the GSUB size is coming from the CJK subset (NotoSansCJKscSubset-Regular.ttf) so trimming that too would help.

dscorbett commented 2 years ago

Trimming Tibetan seems like the best solution for now. The bulk of NotoSansCJKscSubset-Regular.ttf’s GSUB comes from its localized forms, and it would be a shame to drop support for localized forms.

FYI, GoNotoContemporary.ttf currently doesn’t support Japanese or Korean. Supporting them in NotoSansCJKscSubset-Regular.ttf will make its GSUB much larger, in which case even discarding \.[23] might not be enough.

satbyy commented 2 years ago

Thanks for your feedback.

FYI, GoNotoContemporary.ttf currently doesn’t support Japanese or Korean.

Are you sure? Setting the correct language displays Japanese/Korean glyphs for me. It is just that the Simplified Chinese is the default. For example:

for lang in zh_CN zh_TW ja_JP ko_KR; do
    hb-view --language=$lang --unicodes="U+904D"  ~/.fonts/GoNotoContemporary.ttf;
done
dscorbett commented 2 years ago

I mean that it doesn’t support Hiragana, Katakana, or Hangul, so it can’t be used for Japanese or Korean, even if it has localized ideographs for them.

satbyy commented 2 years ago

Ah, are you saying that I need to include Hangul (U+1100 – U+11FF), Hiragana (U+3040 – U+309F), Katakana (U+30A0 – U+30FF) Unicode blocks? I read that Unihan IICore contains a union of all the basic characters for including Japanese and Korean, so I thought there is nothing else to be done.

dscorbett commented 2 years ago

Yes: International Ideographs Core is only for ideographs. It doesn’t cover other letters, symbols, or punctuation needed for CJK.