search

satbyy / go-noto-universal

Noto fonts go universal! Download pan-Unicode, merged Noto fonts according to time of usage (current, ancient) or geographical region (South Asia, SE Asia, Africa-MiddleEast, Europe-Americas).
Other
151 stars 21 forks source link

Replace GitHub URLs with CDN #66

Closed satbyy closed 1 year ago

satbyy commented 1 year ago

Fixes many TODOs.

satbyy commented 1 year ago

The Duployan font from upstream CDN doesn't seem to work. Some trouble merging 'CFF' though I'm not sure it really is CFF.

For now switch back to using GitHub URL.

Merging 35 fonts...
Merging 'CFF '.
Traceback (most recent call last):
  File "/home/runner/work/go-noto-universal/go-noto-universal/venv/bin/pyftmerge", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/runner/work/go-noto-universal/go-noto-universal/venv/lib/python3.11/site-packages/fontTools/misc/loggingTools.py", line 375, in wrapper
    return func(*args, **kwds)
           ^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/go-noto-universal/go-noto-universal/venv/lib/python3.11/site-packages/fontTools/merge/__init__.py", line 205, in main
    font = merger.merge(fontfiles)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/go-noto-universal/go-noto-universal/venv/lib/python3.11/site-packages/fontTools/merge/__init__.py", line 118, in merge
    table = clazz(tag).merge(self, tables)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/go-noto-universal/go-noto-universal/venv/lib/python3.11/site-packages/fontTools/merge/tables.py", line 242, in merge
    if any(hasattr(table.cff[0], "FDSelect") for table in tables):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/go-noto-universal/go-noto-universal/venv/lib/python3.11/site-packages/fontTools/merge/tables.py", line 242, in <genexpr>
    if any(hasattr(table.cff[0], "FDSelect") for table in tables):
                   ^^^^^^^^^
AttributeError: 'NotImplementedType' object has no attribute 'cff'