Closed matiasg closed 2 years ago
The original code in get_sun seems to come from https://la.mathworks.com/matlabcentral/fileexchange/23051-vectorized-solar-azimuth-and-elevation-estimation
get_sun
There is a bug there with a hardcoded oblecl as 23.4406. The difference is really minuscule, it affects the 4th significant digit. There is a second bug with a sign, but it is not noticeable since the corresponding term is always 0
oblecl
23.4406
This PR fixes both bugs.
The original code in
get_sunseems to come from https://la.mathworks.com/matlabcentral/fileexchange/23051-vectorized-solar-azimuth-and-elevation-estimationThere is a bug there with a hardcoded
obleclas23.4406. The difference is really minuscule, it affects the 4th significant digit. There is a second bug with a sign, but it is not noticeable since the corresponding term is always 0This PR fixes both bugs.