search

satellogic / telluric

telluric is a Python library to manage vector and raster geospatial data in an interactive and easy way
MIT License
87 stars 18 forks source link

Add another filter for corner case in merge_all #299

Closed marcronq closed 3 years ago

marcronq commented 3 years ago

There is another merged PR that focused on this same issue https://github.com/satellogic/telluric/pull/296 but it was discovered then that the very same thing can raise another problem and it is not covered by that fix.

When trying to merge some images using telluric.georaster.merge_all, if a pair of them are really close (around images resolution) it appears that their footprints intersect but if you try to crop those images an exception is raised stating that a negative width/height can't be used. This PR just adds a catch for ValueError to avoid that problem and let other images to merge, if they can.

drnextgis commented 3 years ago

@arielze do you think this would be better?

merged = merge_all([one, other], dest_resolution=(1, 1), roi=roi)
assert merged == one
arielze commented 3 years ago

yes, that is better, because it makes clear what is expected to happen