search

sathyamoorthi / brackets-sidebar-plus

adding auto show/hide to sidebar
27 stars 6 forks source link

Simplify logic and fix bug (or two). #1

Closed jeffslofish closed 11 years ago

jeffslofish commented 11 years ago

Thank your for the idea of this extension. I liked it so much I decided to hack on it!

sathyamoorthi commented 11 years ago

Jeff,

Thanks for your pull request. I noticed some problem to accept it as it is.

1.Once we hide sidebar, we can't stick it back permanently. But this is possible on previous version via View->Show Sidebar.

2.We will lose animation which i felt really cool about this.

give me this weekend, i'll try to fix issue #2.

sathyamoorthi commented 11 years ago

Hi,

I fixed both issues from README.

Actually, i like your code. It is very simple and will surely work good for long time. In my code, i used lot of selectors, which may get changed in newer versions. I need to update at that time again. But i like the transition for show and hide. That adds lot of lines on my code.

Let me know what you think on this.