search

satijalab / sctransform

R package for modeling single cell UMI expression data using regularized negative binomial regression
GNU General Public License v3.0
213 stars 33 forks source link

Please specify Matrix version with equal separation signs #148

Closed tillea closed 1 year ago

tillea commented 2 years ago

Hi, I'm aware that in R the signs '.' and '-' are sorting equally in version numbers. This is not true for Debian package versions und thus for the latest Debian package I needed the following patch:

-Imports: dplyr, magrittr, MASS, Matrix (>= 1.5.0), methods,
+Imports: dplyr, magrittr, MASS, Matrix (>= 1.5-0), methods,

for the version of Matrix. It would be extremely helpful if you would simply keep the same spelling for version numbers as the authors of a package have decided for. Kind regards, Andreas.

saketkc commented 2 years ago

Thanks for reporting this and for the patch. I will fix this in the next release.

tillea commented 2 years ago

Am Mon, Sep 26, 2022 at 04:57:29PM -0700 schrieb Saket Choudhary:

Thanks for reporting this and for the patch. I will fix this in the next release. Thanks a lot for your cooperation, Andreas.

tillea commented 1 year ago

Hi, unfortunately in version 0.4.0 the issue persists. I can patch it again inside the Debian package, but it would be great if you could commit a fix to Git to close this issue. Thanks a lot, Andreas.

saketkc commented 1 year ago

Apologies that I missed this in the latest release. For now I would recommend patching it at your end and will incorporate the fix in the next release.

tillea commented 1 year ago

Am Tue, Oct 17, 2023 at 05:15:29AM -0700 schrieb Saket Choudhary:

Apologies that I missed this in the latest release. For now I would recommend patching it at your end and will incorporate the fix in the next release.

I've done so, yes. I'd simply recommend you push a fix to Git and close this issue to make sure it gets fixed next time. ;-) Kind regards, Andreas.

saketkc commented 1 year ago

Fixed in develop branch, thanks!