Delete get_nz_median, fix usage in get_residuals_var, add unit tests

satijalab / sctransform

R package for modeling single cell UMI expression data using regularized negative binomial regression

GNU General Public License v3.0

203 stars 33 forks source link

Delete get_nz_median, fix usage in get_residuals_var, add unit tests #155

Closed boomanaiden154 closed 1 year ago

boomanaiden154 commented 1 year ago

This patch deletes some leftover artifacts from get_nz_median (such as the documentation), fixes the usage of get_nz_median2 in get_residual_var since it also needs to support subsetting genes, and adds two unit tests to ensure that get_nz_median2 is functioning correctly.

This should keep the fast performance of the implementation for get_nz_median2 while also allowing gene subsetting.

Co-authored-by: @ScreachingFire

saketkc commented 1 year ago

Thanks very musch @boomanaiden154 and @screachingfire! This looks good.