fixed batch variable or latent variable attribute checking

satijalab / sctransform

R package for modeling single cell UMI expression data using regularized negative binomial regression

GNU General Public License v3.0

203 stars 33 forks source link

fixed batch variable or latent variable attribute checking #89

Closed kmwinkley closed 3 years ago

kmwinkley commented 3 years ago

If SCTransform is used with a batch or latent variable, it confirms that there are no missing values in the requested variable. However, it calls is.nan and is.infinite on a list which is not allowed. This error only appears when calling SCTransform with a batch or latent variable, otherwise this step is skipped. This is a fix for issue #88

ChristophH commented 3 years ago

Thank you for this PR. While your fix is perfectly acceptable, I opted for a different approach that allows me to print a more helpful error message. See commit 63c0eda