search

satijalab / seurat-data

Dataset distribution for Seurat
GNU General Public License v3.0
129 stars 48 forks source link

Remove warning #45

Closed bbimber closed 2 years ago

bbimber commented 2 years ago

When loading SeuratData:

library(SeuratData)

A series of warnings are logged, also reported in #41. This is a simple proposal to remove them.

aaronwolen commented 2 years ago

Came here to post the same fix 😄

mojaveazure commented 2 years ago

Thanks for the PR and apologies for the delayed reponse!

bbimber commented 2 years ago

@mojaveazure Thanks, and I believe this change in R explains why this became a more significant problem:

https://cran.r-project.org/index.html

Calling if() or while() with a condition of length greater than one gives an error rather than a warning. Consequently, environment variable _R_CHECK_LENGTH_1CONDITION no longer has any effect.