search

satijalab / seurat

R toolkit for single cell genomics
http://www.satijalab.org/seurat
Other
2.29k stars 914 forks source link

Spline bug in FeatureScatter in development version #2151

Closed pebonte closed 5 years ago

pebonte commented 5 years ago

Hi all,

I just want to report a bug. When making a scatter plot with featureScatter and adding the smoothing loess/spline argument, there is a . bug when the feature contains a "-" character.

This portion of code will work correctly : FeatureScatter(object = integrated.te.uniq, feature1 = "RLTR17B-Mm-dup19149", feature2 = "sig.gene.interferon", group.by = "merged_gene_cluster2" , cols = colors_exhausted, slot = "data")

Capture d’écran 2019-09-30 à 15 13 40

But adding the span argument will cause an error because there is an "-" character in the name of the feature (in the assay@integrated slot).

FeatureScatter(object = integrated.te.uniq, feature1 = "RLTR17B-Mm-dup19149", feature2 = "sig.gene.interferon", group.by = "merged_gene_cluster2" , cols = colors_exhausted, slot = "data", span = TRUE)

Capture d’écran 2019-09-30 à 15 13 12

(which translate by object RLTR17B not found)

I just wanted to report it and hopefully it will be corrected.

Thank you for your hardwork.

Best,

Pierre-Emmanuel

andrewwbutler commented 5 years ago

Thanks for reporting! We are able to reproduce the issue and are working on a fix. Will post back here once addressed.

mojaveazure commented 5 years ago

This should be fixed in the development version of Seurat. To install the development version of Seurat, please see the instructions here.